drivers: tdk: Define the trigger as a pointer to allow dereferencing within the trigger handler callback. #97151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
afontaine-invn,
asemjonovs,
avisconti,
gjabouley-invn,
jeppenodgaard,
rbuisson-invn,
sriccardi-invn,
teburd,
tristan-google,
ubieda and
yperess
janchri
force-pushed
the
fix/icm_trigger
branch
from
a6ae71e to
05e67b8
Compare
janchri
force-pushed
the
fix/icm_trigger
branch
2 times, most recently
from
188cad6 to
6347062
Compare
|
@janchri can you please update the commit message to indicate it |
|
Do I add this in the body of the commit message? |
MaureenHelm
previously approved these changes
Oct 8, 2025
janchri
force-pushed
the
fix/icm_trigger
branch
from
053bbc7 to
6347062
Compare
…R_OF Allows CONTAINER_OF inside trigger handler to be used to obtain a valid ptr to the composite struct consisting of a struct sensor_trigger trig. Fixes zephyrproject-rtos#97124 Signed-off-by: Christoph Jans <[email protected]>
janchri
force-pushed
the
fix/icm_trigger
branch
from
6347062 to
9b07667
Compare
|
Included the fix inside the commit body message. |
|
MaureenHelm
approved these changes
Oct 9, 2025
kartben
approved these changes
Oct 9, 2025
ubieda
reviewed
Oct 9, 2025
ubieda
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the issue with CONTAINER_OF dereferencing in the trigger handler (see the following issue: #97124).
With this fix, it is possible to define a custom-made
and by setting
sensor_trigger_set(dev, &sdevice.trigger, handler)while initialisation, access inhandler()viaCONTAINER_OFto the underlyingstruct sdeviceis granted.fixes: #97124